-
Notifications
You must be signed in to change notification settings - Fork 81
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Release candid 0.10 #493
Merged
Merged
Release candid 0.10 #493
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Currently, the `candid` crate mainly consists of two parts: * Candid data encoding/decoding * Parser and derived functionality (bindgen) The second part evolves fast which forces us to bump major version frequently. Such version bumps propagated to the downstream projects (agent-rs, cdk-rs, sdk, ic monorepo, etc). By splitting out `candid_parser`, we expect to have a stable `candid` crate. Also, I move `Principal` into a separate `ic_principal` crate. Therefore, we can provide a lightweight dependency for those who only need `Principal`. ## Notable changes * Some private or crate public methods are now public since they are called cross-crate * Add `parse_idl_args()` and `parse_idl_value()` because in `candid_parser` we cannot implement `FromStr` for `IDLArgs` and `IDLValue` which are defined in `candid`. * `TypeEnv` is defined in `candid`, so we can't implement type method `ast_to_type` in `candid_parser`. Instead I turned it into a function which takes `TypeEnv` as the first argument. Similarly, `size_helper()` and `size()` are changed.
* remove num_enum * clean up parser dependencies * checkpoint * value feature * remove codespan * fix * fix * pretty * remove mute_warning * fix * pretty refactor * fix * reexport candid in parser * fix * fix * fix * bignum feature * bump candid_derive * silence subtyping in decoder * fix service_equal error reporting (#486) * add IDLValue::Blob * builder for config * fix * fix
* fix service_equal error reporting (#486) * Add Arbitrary for Principal and extend random for Func * Use instead of * fmt * add arbitrary for principal --------- Co-authored-by: Yan Chen <[email protected]>
Benchmark for 2d15cf5Click to view benchmark
|
rvanasa
approved these changes
Nov 16, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Break
candid
crates intocandid
,candid_parser
andic_principal
.